Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 )
Change subject: [metrics] Add a metric to count merged entities when merge metrics ...................................................................... Patch Set 10: > Patch Set 10: > > > Looks good but IWYU is still complaining. What happens if you add > > its recommendations? > > I went that route: compilation fails if doing so. I think those forward > declarations confuse IWYU. The forward declarations are necessary if trying > to keep InvalidateEpoch() as a non-public method: I recommended doing so. The IWYU message seems caused by L262~L266, you can check that by patch set 7, however, I'm not sure how to fix it. :( -- To view, visit http://gerrit.cloudera.org:8080/14128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1 Gerrit-Change-Number: 14128 Gerrit-PatchSet: 10 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2019 06:43:05 +0000 Gerrit-HasComments: No
