Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14354 )
Change subject: KUDU-1938 Make UTF-8 truncation faster pt 2 ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG@22 PS11, Line 22: [ RUN ] CharUtilTest.StressTestUtf8 : [ OK ] CharUtilTest.StressTestUtf8 (9285 ms) > I don't think the improvements (and scope) here justify requiring AVX in Ku I checked that and that was about AVX2 which was addded in Haswell in 2013. I'm talking about "plain old" AVX which was first added to Sandy Bridge in 2011. Anyway, I'm fine with not adding it here, but do you think it's not worth a discussion on dev@ in general? Also, I'm not advocating adding it as a requirement, only to add it as an optional flag which would be disabled by default for now. -- To view, visit http://gerrit.cloudera.org:8080/14354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a491157dd5c8b4815030bbda921a0afc0bafd28 Gerrit-Change-Number: 14354 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Nov 2019 22:22:39 +0000 Gerrit-HasComments: Yes
