Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14354 )
Change subject: KUDU-1938 Make UTF-8 truncation faster pt 2 ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14354/11//COMMIT_MSG@22 PS11, Line 22: [ RUN ] CharUtilTest.StressTestUtf8 : [ OK ] CharUtilTest.StressTestUtf8 (9285 ms) > I checked that and that was about AVX2 which was addded in Haswell in 2013. Ah, sorry for conflating AVX with AVX2. I'd be supportive of such a discussion if it's important to you. I don't feel strongly because I'm not aware of any other CPU-based optimizations that are currently on hold because of our poor handling of "new" instruction sets. Bear in mind that addressing this correctly probably means changes to both the Kudu and thirdparty builds, and we'll need to make sure we separate the build machine's capabilities from that of the target machine. So I guess what I'm saying is we should only go down this path if there are meaningful rewards at the end of it. -- To view, visit http://gerrit.cloudera.org:8080/14354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a491157dd5c8b4815030bbda921a0afc0bafd28 Gerrit-Change-Number: 14354 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Nov 2019 22:34:38 +0000 Gerrit-HasComments: Yes
