[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 14: > Patch Set 12: > > I owe you an apology. I should have looked at the existing C++ client code > for handling ResourceMetricsPB when I reviewed your Java client changes. I > only now did that and saw that it followed your original design of exposing > the metrics as a map, and using protobuf reflection to populate the map. > > In the interest of consistency, both clients should follow the same approach, > and since the C++ client support already exists, changing its API would break > backwards compatibility. Could you restore the map and reflection based code > you had (modulo my feedback on it)? > > Sorry again for not noticing this earlier; I had no idea we already supported > this in the C++ client. No problem, I updated the patch. I also added more comments to ResourceMetricsPB to document each metric. -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30a7e82357fe2fc28f6d316378a612af43d8c96 Gerrit-Change-Number: 8375 Gerrit-PatchSet: 14 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2019 06:50:14 +0000 Gerrit-HasComments: No
