Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@1157 PS14, Line 1157: resp.getResourceMetrics()); This may not actually exist in the response (i.e. very old versions of Kudu), so we should probably check hasResourceMetrics and act accordingly. http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java File java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java: http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@38 PS14, Line 38: * This class is not threadsafe. The C++ equivalent is thread-safe, so maybe we should consider doing the same here, with a concurrent map or something. http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@68 PS14, Line 68: Preconditions.checkArgument(resourceMetricsPb != null); Use Preconditions.checkNotNull(). But we need to fail gracefully if the scan RPC response doesn't have a ResourceMetricsPB, so maybe you don't want that at all? -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30a7e82357fe2fc28f6d316378a612af43d8c96 Gerrit-Change-Number: 8375 Gerrit-PatchSet: 14 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2019 00:18:25 +0000 Gerrit-HasComments: Yes
