[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@1157 PS14, Line 1157: : AsyncKuduClient.NO_TIMESTAMP, > This may not actually exist in the response (i.e. very old versions of Kudu Modified to set the resourceMetricsPB variable to null if doesn't exist. Also I don't call update if resourceMetricsPb is null. http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java File java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java: http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@38 PS14, Line 38: * metrics associated with a scanner. > The C++ equivalent is thread-safe, so maybe we should consider doing the sa Done http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@68 PS14, Line 68: } > Use Preconditions.checkNotNull(). But we need to fail gracefully if the sca This is only called if the scan RPC response has a ResourceMetricsPB, so I changed it to Preconditions.checkNotNull. -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30a7e82357fe2fc28f6d316378a612af43d8c96 Gerrit-Change-Number: 8375 Gerrit-PatchSet: 15 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2019 08:45:39 +0000 Gerrit-HasComments: Yes
