Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java File java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java: http://gerrit.cloudera.org:8080/#/c/8375/14/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@50 PS14, Line 50: */ Could we retain a method like this that makes a copy of the map? You'd probably want to convert it into a simple HashMap<String, Long> before returning it though. http://gerrit.cloudera.org:8080/#/c/8375/15/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java File java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java: http://gerrit.cloudera.org:8080/#/c/8375/15/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@39 PS15, Line 39: * <p> Don't need this <p> without anything after it. http://gerrit.cloudera.org:8080/#/c/8375/15/java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java@49 PS15, Line 49: * @return the value of the named metric; if the metric is not found, returns null The equivalent C++ API actually does return 0 if the metric is not found, so despite my previous feedback on the matter, we should probably be consistent. -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30a7e82357fe2fc28f6d316378a612af43d8c96 Gerrit-Change-Number: 8375 Gerrit-PatchSet: 15 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2019 19:51:49 +0000 Gerrit-HasComments: Yes
