YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14760 )
Change subject: KUDU-2993: don't require update_dirs to fix directory inconsistencies ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/14760/9/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/14760/9/src/kudu/fs/data_dirs.cc@713 PS9, Line 713: return Status::NotFound( This place may have a problem, for example, fs_data_dirs is "/kudu/a,/kudu/b,/kudu/c", then we change it to "/kudu/d,kudu/e", or "/kudu/c,kudu/d" but "/kudu/c" is failed. First we will try do open, after we load instance from disk, we cannot find a healthy instance, so we return "NotFound", then in the server_base.cc:ServerBase::init() we will try to create a new, but it also will failed. I think the logic is a little complicated, especially after adding the WAL directories, maybe one succeeds and the other fails. So I think the upper level ("FsManager and ServerBase") should handle all the mistakes better. -- To view, visit http://gerrit.cloudera.org:8080/14760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3027e7edb5c60e96ced6160fec1a380b38353a5 Gerrit-Change-Number: 14760 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2019 06:48:43 +0000 Gerrit-HasComments: Yes
