Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14760 )
Change subject: KUDU-2993: don't require update_dirs to fix directory inconsistencies ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/14760/9/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/14760/9/src/kudu/fs/data_dirs.cc@713 PS9, Line 713: return Status::NotFound( > This place may have a problem, for example, fs_data_dirs is "/kudu/a,/kudu/ That's a good observation, but this was intentional. At least, how the current update_dirs tool works, if you were to move from "/kudu/a" to "/kudu/b" with no overlap, the tool would fail. I guess for the WALs case, we could try opening the DataDirManager and the WalDirManager, and if _both_ of them return NotFound, try running Create() for both, and return and return an error otherwise. Or if either of them are NotFound, run Create() on whichever one was NotFound. It depends on what behavior seems more intuitive. In either case, I agree, ServerBase will have to catch these NotFound errors, but that is already the case today. -- To view, visit http://gerrit.cloudera.org:8080/14760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3027e7edb5c60e96ced6160fec1a380b38353a5 Gerrit-Change-Number: 14760 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Tue, 26 Nov 2019 21:23:44 +0000 Gerrit-HasComments: Yes
