YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14760 )
Change subject: KUDU-2993: don't require update_dirs to fix directory inconsistencies ...................................................................... Patch Set 9: Yes, I agree with Moving /kudu/a to /kudu/b doesn't work. In the old version, we allowed data directories to be failed when we start tserver. But when we use update_dirs, we must make sure all data directories are healthy, in DataDirManager::Open(), we first load instance, if it's update_dirs, we check every instance, if it's not found, we create it, if it's not healthy, we will return, and after creating, we need reload instance and check every instance again, if it's not healthy, we will return. What I mean is we must make sure every directory healthy in the new --fs_data_dirs then update_dirs can work succees. The check code appears to have been deleted during the change. So there's a conflict here, in the reboot we do not need to make sure every dir to be healthy, but in update_dirs we must do. And if we want to join the two logics together, I think we must resolve this conflict. So I say if changing "/kudu/a,kudu/b" to "/kudu/b,/kudu/c", when "kudu/b" is unhealthy, this code may behavior differet from update_dirs. -- To view, visit http://gerrit.cloudera.org:8080/14760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3027e7edb5c60e96ced6160fec1a380b38353a5 Gerrit-Change-Number: 14760 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Wed, 27 Nov 2019 04:54:15 +0000 Gerrit-HasComments: No
