Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14760 )

Change subject: KUDU-2993: don't require update_dirs to fix directory 
inconsistencies
......................................................................


Patch Set 9:

> Patch Set 9:
>
> I think it's a little different with update_dirs. Update_dirs must make sure 
> that all directories in the new config are healthy. This assurance was 
> removed in the new version. And update_dirs allow changes from 
> "/kudu/a,kudu/b" to "/kudu/b,/kudu/c", if both "/kudu/b" and "/kudu/c" are 
> healthy.

Are you saying that we should the behavior in update_dirs tool that it only 
succeeds if all the directories are healthy? I'm not sure I understand what 
you're pointing out.

Moving /kudu/a,/kudu/b to /kudu/b,/kudu/c works before and after this change. 
Moving /kudu/a to /kudu/b doesn't, and it never did.


-- 
To view, visit http://gerrit.cloudera.org:8080/14760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3027e7edb5c60e96ced6160fec1a380b38353a5
Gerrit-Change-Number: 14760
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: YangSong <[email protected]>
Gerrit-Comment-Date: Wed, 27 Nov 2019 04:04:12 +0000
Gerrit-HasComments: No

Reply via email to