Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14849 )
Change subject: KUDU-2992: Avoid sending duplicated requests in catalog_manager ...................................................................... Patch Set 1: (4 comments) I'm a little nervous about using the description as a unique key. They look immutable and unique, but they're also just supposed to be descriptive. Could you add a test showing that this works the way you expect? http://gerrit.cloudera.org:8080/#/c/14849/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14849/1/src/kudu/master/catalog_manager.cc@3507 PS1, Line 3507: MarkComplete(); Will a new deletion task be created the next time the tserver heartbeats? Or will that tablet be missing from the tablet report? http://gerrit.cloudera.org:8080/#/c/14849/1/src/kudu/master/catalog_manager.cc@4314 PS1, Line 4314: // This is a floating task (since the table does not exist) created in : // response to a tablet report. : rpc->AddRef(); Do we even have these anymore? I don't think we do. Could simplify this code a bit. http://gerrit.cloudera.org:8080/#/c/14849/1/src/kudu/master/catalog_manager.cc@5529 PS1, Line 5529: LOG(WARNING) << "Do not send duplicated request: " + task->description(); Seems like this will be noisy. Throttle or VLOG? http://gerrit.cloudera.org:8080/#/c/14849/1/src/kudu/master/catalog_manager.cc@5533 PS1, Line 5533: pending_tasks_.emplace(task->description(), task); Didn't we just do this on L5528? -- To view, visit http://gerrit.cloudera.org:8080/14849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If090723821bd78e14a3c54a35cb5e471320002e9 Gerrit-Change-Number: 14849 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 05 Dec 2019 21:12:45 +0000 Gerrit-HasComments: Yes
