Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14849 )

Change subject: KUDU-2992: Avoid sending duplicated requests in catalog_manager
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14849/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14849/2//COMMIT_MSG@16
PS2, Line 16: existing
> existing
Done


http://gerrit.cloudera.org:8080/#/c/14849/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/14849/2/src/kudu/master/catalog_manager.cc@4363
PS2, Line 4363:
> Add a space before 'c'
Done


http://gerrit.cloudera.org:8080/#/c/14849/2/src/kudu/master/catalog_manager.cc@5511
PS2, Line 5511:
> Old style was correct: "MonitoredTask* task", not "MonitoredTask *task"
Done


http://gerrit.cloudera.org:8080/#/c/14849/2/src/kudu/master/catalog_manager.cc@5519
PS2, Line 5519:       break;
> Don't need std:: prefixes in .cc files.
Done



--
To view, visit http://gerrit.cloudera.org:8080/14849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If090723821bd78e14a3c54a35cb5e471320002e9
Gerrit-Change-Number: 14849
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Tue, 10 Dec 2019 13:47:39 +0000
Gerrit-HasComments: Yes

Reply via email to