Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14849 )
Change subject: KUDU-2992: Avoid sending duplicated requests in catalog_manager ...................................................................... Patch Set 2: (4 comments) ASAN tests show a memory leak. http://gerrit.cloudera.org:8080/#/c/14849/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14849/2//COMMIT_MSG@16 PS2, Line 16: exsiting existing http://gerrit.cloudera.org:8080/#/c/14849/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14849/2/src/kudu/master/catalog_manager.cc@4363 PS2, Line 4363: c Add a space before 'c' http://gerrit.cloudera.org:8080/#/c/14849/2/src/kudu/master/catalog_manager.cc@5511 PS2, Line 5511: MonitoredTask *task Old style was correct: "MonitoredTask* task", not "MonitoredTask *task" Elsewhere too. http://gerrit.cloudera.org:8080/#/c/14849/2/src/kudu/master/catalog_manager.cc@5519 PS2, Line 5519: void TableInfo::RemoveTask(const std::string& tablet_id, MonitoredTask *task) { Don't need std:: prefixes in .cc files. -- To view, visit http://gerrit.cloudera.org:8080/14849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If090723821bd78e14a3c54a35cb5e471320002e9 Gerrit-Change-Number: 14849 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 09 Dec 2019 20:04:17 +0000 Gerrit-HasComments: Yes
