Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14849 )
Change subject: KUDU-2992: Avoid sending duplicated requests in catalog_manager ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14849/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14849/1/src/kudu/master/catalog_manager.cc@3507 PS1, Line 3507: TabletServerErrorPB::Code_Name(code), status.ToString()); > Will a new deletion task be created the next time the tserver heartbeats? O Here we just abondon retrying to send the request, if the tablet hasn't been deleted and it report to master, the deletion task will be created again. http://gerrit.cloudera.org:8080/#/c/14849/1/src/kudu/master/catalog_manager.cc@4314 PS1, Line 4314: : return Status::OK(); : } > Do we even have these anymore? I don't think we do. Could simplify this cod Done http://gerrit.cloudera.org:8080/#/c/14849/1/src/kudu/master/catalog_manager.cc@5529 PS1, Line 5529: } > Seems like this will be noisy. Throttle or VLOG? Done http://gerrit.cloudera.org:8080/#/c/14849/1/src/kudu/master/catalog_manager.cc@5533 PS1, Line 5533: task->Release(); > Didn't we just do this on L5528? Done -- To view, visit http://gerrit.cloudera.org:8080/14849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If090723821bd78e14a3c54a35cb5e471320002e9 Gerrit-Change-Number: 14849 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 09 Dec 2019 13:24:18 +0000 Gerrit-HasComments: Yes
