Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14849 )
Change subject: KUDU-2992: Avoid sending duplicated requests in catalog_manager ...................................................................... Patch Set 2: > Patch Set 1: > > (4 comments) > > I'm a little nervous about using the description as a unique key. They look > immutable and unique, but they're also just supposed to be descriptive. > > Could you add a test showing that this works the way you expect? Yes, using the description as a unique key is not suitable, since the description includes table_name in AlterTableRPC, and the table_name would be not consistent before and after the RPC call. I did some modifications and now we only handle duplicate requests in ProcessTabletReport. -- To view, visit http://gerrit.cloudera.org:8080/14849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If090723821bd78e14a3c54a35cb5e471320002e9 Gerrit-Change-Number: 14849 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 09 Dec 2019 13:24:44 +0000 Gerrit-HasComments: No
