Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14849 )
Change subject: KUDU-2992: Avoid sending duplicated requests in catalog_manager ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/14849/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14849/4/src/kudu/master/catalog_manager.cc@3490 PS4, Line 3490: > There's another case below us, so maybe remove this. Done http://gerrit.cloudera.org:8080/#/c/14849/4/src/kudu/master/catalog_manager.cc@3499 PS4, Line 3499: : target_ts_desc_->ToString() > Swap these two arguments Done http://gerrit.cloudera.org:8080/#/c/14849/4/src/kudu/master/catalog_manager.cc@3569 PS4, Line 3569: return Substitute("AlterTable RPC for tablet $0 (table $1, > Do you think it's worth including the schema version number? Or, because Al I think maybe it's better to include the schema version, since the schema version number could distinguish different AlterTable requests. If the master has already sent a AlterTable request to a tablet but it hasn't been done, and the table schema altered again, it's better to send another AlterTable request when processing the next TabletReports from tservers. http://gerrit.cloudera.org:8080/#/c/14849/4/src/kudu/master/catalog_manager.cc@5561 PS4, Line 5561: > Unnecessary parentheses here? Done http://gerrit.cloudera.org:8080/#/c/14849/4/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/14849/4/src/kudu/master/master-test.cc@1796 PS4, Line 1796: ReplicaManagementInfoPB::PREPARE_REPLACEMENT_BEFORE_EVICTION); : : { > nit: could just use PREPARE_REPLACEMENT_BEFORE_EVICTION, since that's the m Done -- To view, visit http://gerrit.cloudera.org:8080/14849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If090723821bd78e14a3c54a35cb5e471320002e9 Gerrit-Change-Number: 14849 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2019 13:13:50 +0000 Gerrit-HasComments: Yes
