Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14849 )
Change subject: KUDU-2992: Avoid sending duplicated requests in catalog_manager ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/14849/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14849/2/src/kudu/master/catalog_manager.cc@5531 PS2, Line 5531: void TableInfo::WaitTasksCompletion() { : int wait_time = 5; : while (1) { > It seems impossible that the last ref to the TableInfo is in 'task', at lea That's not entirely true; VisitTablesAndTabletsUnlocked will clear out the TableInfo maps, which could cause them to be destroyed. That said, it'll also abort and wait for all tasks before doing so, meaning ReleaseTask called from UnregisterAsyncTask can't be called concurrently. http://gerrit.cloudera.org:8080/#/c/14849/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14849/4/src/kudu/master/catalog_manager.cc@5561 PS4, Line 5561: tasks->push_back((task.second)); Unnecessary parentheses here? -- To view, visit http://gerrit.cloudera.org:8080/14849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If090723821bd78e14a3c54a35cb5e471320002e9 Gerrit-Change-Number: 14849 Gerrit-PatchSet: 4 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 11 Dec 2019 21:26:22 +0000 Gerrit-HasComments: Yes
