Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14912 )
Change subject: [metrics] Add a new metric 'last_consult_timestamp' for tablet ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14912/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14912/1//COMMIT_MSG@10 PS1, Line 10: last write or scan timestamp of the tablet. We can judge whether a What will you do with the knowledge of a cold or hot tablet? http://gerrit.cloudera.org:8080/#/c/14912/1/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/14912/1/src/kudu/tablet/tablet_metrics.cc@136 PS1, Line 136: METRIC_DEFINE_gauge_uint64(tablet, last_consult_timestamp, "Last Consult Timestamp", Does it make sense to separate this into two metrics? One for writes and one for reads? http://gerrit.cloudera.org:8080/#/c/14912/1/src/kudu/tablet/tablet_metrics.cc@325 PS1, Line 325: // TODO(yingchun): Should use kMax type. Did you intend to leave this todo in? And the one below. -- To view, visit http://gerrit.cloudera.org:8080/14912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90738ba90eaa8f78c8d721dde2eed2b723d5572d Gerrit-Change-Number: 14912 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 16 Dec 2019 16:33:21 +0000 Gerrit-HasComments: Yes
