Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14912 )
Change subject: [metrics] Add new metrics to indicate the last read/write time ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/14912/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14912/1//COMMIT_MSG@10 PS1, Line 10: 'last_write_elapsed_seconds' for tablet to indicate the last read or > As what you wrote in https://kudu.apache.org/2019/03/05/transparent-hierarc I see, then it's especially important to separate read and write metrics. http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.cc@167 PS3, Line 167: METRIC_DEFINE_gauge_uint64(tablet, last_read_elapsed_seconds, "Last Read Elapsed Seconds", Maybe last_read_elapsed_time? That seems to be more common than listing the units in the metric name. http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.cc@169 PS3, Line 169: "Last read operation elapsed in seconds on this tablet.", Maybe rephrase this to "The elapsed time, in seconds, since the last read operation on this tablet." Same with the comment on the LastReadElapsedSeconds function. http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.cc@173 PS3, Line 173: "Last write operation elapsed in seconds on this tablet.", Maybe rephrase this to "The elapsed time, in seconds, since the last write operation on this tablet." Same with the comment on the LastWriteElapsedSeconds function. -- To view, visit http://gerrit.cloudera.org:8080/14912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90738ba90eaa8f78c8d721dde2eed2b723d5572d Gerrit-Change-Number: 14912 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2019 15:40:52 +0000 Gerrit-HasComments: Yes
