Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14976 )
Change subject: KUDU-3011 p1: metric to count tablet leaders ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG@13 PS7, Line 13: I considered instead having the metric be defined by a functor that : would iterate through all replicas and check each's leadership status. I : opted to not do this, since iterating through and locking each : RaftConsensus instance seemed like it'd be less performant. Did you consider adding such a metric at the master's side? If implementing some sort of leadership balancing, the information on the number of leader replicas need to be aggregated or passed to the masters (assuming masters are the actors who control the leadership rebalancing). And masters already process tablet reports, where the reports have all the information necessary to account for number of leader replicas. http://gerrit.cloudera.org:8080/#/c/14976/7/src/kudu/kserver/kserver.h File src/kudu/kserver/kserver.h: http://gerrit.cloudera.org:8080/#/c/14976/7/src/kudu/kserver/kserver.h@20 PS7, Line 20: #include <stdint.h> nit: consider using <cstdint> -- To view, visit http://gerrit.cloudera.org:8080/14976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6554458a860e34f97af168da7ed786c8ef47e4 Gerrit-Change-Number: 14976 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 06 Jan 2020 20:48:03 +0000 Gerrit-HasComments: Yes
