Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14976 )
Change subject: KUDU-3011 p1: metric to count tablet leaders ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG@10 PS7, Line 10: This is done by plumbing down a top-level gauge down from : the TSTabletManager to each TabletReplica's RaftConsensus instance. Should update this. http://gerrit.cloudera.org:8080/#/c/14976/7/src/kudu/kserver/kserver.cc File src/kudu/kserver/kserver.cc: http://gerrit.cloudera.org:8080/#/c/14976/7/src/kudu/kserver/kserver.cc@166 PS7, Line 166: num_raft_leaders_ = metric_entity()->FindOrCreateGauge(&METRIC_num_raft_leaders, 0); Nit: L147-149 use metric_entity_ rather than the accessor; could you do the same here? -- To view, visit http://gerrit.cloudera.org:8080/14976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6554458a860e34f97af168da7ed786c8ef47e4 Gerrit-Change-Number: 14976 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 06 Jan 2020 21:07:11 +0000 Gerrit-HasComments: Yes
