Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14976 )
Change subject: KUDU-3011 p1: metric to count tablet leaders ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG@13 PS7, Line 13: This is done at the KuduServer to eventually be extensible to count the : number of master system catalog leaders, though that plumbing is left : for a future patch. I've left a TODO where I expect this to happen. : > Right, but is it a requirement to compute these metrics on the tserver sid Ah I see; you mean perhaps using the system catalog to track the number of leaders, and maybe adding some kind of map to the master tracking the number of leaders per server. I'd prefer doing it on the tserver side to avoid potential staleness of the metric. As well, I can see this as a tserver-side metric being used to more easily track hotspotting through thirdparty metrics tooling (e.g. with Cloudera Manager by plotting the metric for every tserver). Doing something similar but aggregating through the master seems more difficult since I think that would mean we'd have to add an RPC to the master and write some code to fetch and display such leadership info. -- To view, visit http://gerrit.cloudera.org:8080/14976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6554458a860e34f97af168da7ed786c8ef47e4 Gerrit-Change-Number: 14976 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 06 Jan 2020 23:03:06 +0000 Gerrit-HasComments: Yes
