Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14976 )
Change subject: KUDU-3011 p1: metric to count tablet leaders ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG@10 PS7, Line 10: This is done by plumbing down a top-level gauge down from : the KuduServer to each TabletReplica's RaftConsensus instance. > Should update this. Done http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG@13 PS7, Line 13: This is done at the KuduServer to eventually be extensible to count the : number of master system catalog leaders, though that plumbing is left : for a future patch. I've left a TODO where I expect this to happen. : > Did you consider adding such a metric at the master's side? This patch just introduces the mechanism for counting leadership; we could certainly extend it to be aggregated on the master later. For my purposes, I only need the info on a per-tserver basis. http://gerrit.cloudera.org:8080/#/c/14976/7/src/kudu/kserver/kserver.h File src/kudu/kserver/kserver.h: http://gerrit.cloudera.org:8080/#/c/14976/7/src/kudu/kserver/kserver.h@20 PS7, Line 20: #include <cstdint> > nit: consider using <cstdint> Done http://gerrit.cloudera.org:8080/#/c/14976/7/src/kudu/kserver/kserver.cc File src/kudu/kserver/kserver.cc: http://gerrit.cloudera.org:8080/#/c/14976/7/src/kudu/kserver/kserver.cc@166 PS7, Line 166: num_raft_leaders_ = metric_entity_->FindOrCreateGauge(&METRIC_num_raft_leaders, 0); > Nit: L147-149 use metric_entity_ rather than the accessor; could you do the Done -- To view, visit http://gerrit.cloudera.org:8080/14976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6554458a860e34f97af168da7ed786c8ef47e4 Gerrit-Change-Number: 14976 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 06 Jan 2020 21:27:23 +0000 Gerrit-HasComments: Yes
