Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14976 )
Change subject: KUDU-3011 p1: metric to count tablet leaders ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14976/7//COMMIT_MSG@13 PS7, Line 13: I considered instead having the metric be defined by a functor that : would iterate through all replicas and check each's leadership status. I : opted to not do this, since iterating through and locking each : RaftConsensus instance seemed like it'd be less performant. > This patch just introduces the mechanism for counting leadership; we could Right, but is it a requirement to compute these metrics on the tserver side? -- To view, visit http://gerrit.cloudera.org:8080/14976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6554458a860e34f97af168da7ed786c8ef47e4 Gerrit-Change-Number: 14976 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 06 Jan 2020 22:32:04 +0000 Gerrit-HasComments: Yes
