Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 )
Change subject: KUDU-2973 Add semi-database support for Ranger ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/common/table_util.cc File src/kudu/common/table_util.cc: http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/common/table_util.cc@97 PS7, Line 97: *ranger_table = Slice(table_name.data() + *separator_idx + 1, > Are these conditions actually possible given the code in L85-95? I don't se well, I don't think it's possible for the database to be empty as if it was we would just default to "default", but the table can be empty if the whole string is empty. We also have a test case for it for ParseHiveTableIdentifier, so it seems we might need to check for it here too. -- To view, visit http://gerrit.cloudera.org:8080/15018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11431ff5bc75540edff56ef3d4ad384fa37d33d5 Gerrit-Change-Number: 15018 Gerrit-PatchSet: 9 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 06 Feb 2020 17:01:14 +0000 Gerrit-HasComments: Yes
