Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15182 )
Change subject: [cmake_modules] shared libs for yaml and gumbo on macOS ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15182/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15182/1//COMMIT_MSG@14 PS1, Line 14: with Nit: too many with http://gerrit.cloudera.org:8080/#/c/15182/1/cmake_modules/FindGumboParser.cmake File cmake_modules/FindGumboParser.cmake: http://gerrit.cloudera.org:8080/#/c/15182/1/cmake_modules/FindGumboParser.cmake@25 PS1, Line 25: gumbo If libgumbo.so (or libgumbo.dylib on macOS) is missing, does this match against libgumbo.a? -- To view, visit http://gerrit.cloudera.org:8080/15182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e56b9dd988501af010bbd1a256671b0460f526 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Feb 2020 20:20:50 +0000 Gerrit-HasComments: Yes
