Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15182 )
Change subject: [cmake_modules] shared libs for yaml and gumbo on macOS ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15182/2/cmake_modules/FindGumboParser.cmake File cmake_modules/FindGumboParser.cmake: http://gerrit.cloudera.org:8080/#/c/15182/2/cmake_modules/FindGumboParser.cmake@33 PS2, Line 33: find_library(GUMBO_PARSER_SHARED_LIB gumbo What about replacing 'gumbo' with 'libgumbo${CMAKE_SHARED_LIBRARY_SUFFIX}'? Would that work without the set/restore stuff? https://cmake.org/cmake/help/latest/variable/CMAKE_SHARED_LIBRARY_SUFFIX.html BTW, I'd be fine with doing what every Find*.cmake does in this patch, then maybe doing this sort of robustness fix in a separate patch across the board. -- To view, visit http://gerrit.cloudera.org:8080/15182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e56b9dd988501af010bbd1a256671b0460f526 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2020 05:53:41 +0000 Gerrit-HasComments: Yes
