Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15182 )
Change subject: [cmake_modules] shared libs for yaml and gumbo on macOS ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15182/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15182/1//COMMIT_MSG@14 PS1, Line 14: with > Nit: too many with Done http://gerrit.cloudera.org:8080/#/c/15182/1/cmake_modules/FindGumboParser.cmake File cmake_modules/FindGumboParser.cmake: http://gerrit.cloudera.org:8080/#/c/15182/1/cmake_modules/FindGumboParser.cmake@25 PS1, Line 25: gumbo > If libgumbo.so (or libgumbo.dylib on macOS) is missing, does this match aga Yup, it happily consumes the static library as a dynamic one here if the file of the actual shared library is missing: Added shared library dependency gumbo-parser: /Users/aserbin/Projects/kudu/thirdparty/installed/uninstrumented/lib/libgumbo.a I sketched a way to handle that in a more reliable way, but it would be necessary to make it more generic and apply to other Find*.cmake files as well. -- To view, visit http://gerrit.cloudera.org:8080/15182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e56b9dd988501af010bbd1a256671b0460f526 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2020 01:51:15 +0000 Gerrit-HasComments: Yes
