Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15182 )
Change subject: [cmake_modules] shared libs for yaml and gumbo on macOS ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15182/2/cmake_modules/FindGumboParser.cmake File cmake_modules/FindGumboParser.cmake: http://gerrit.cloudera.org:8080/#/c/15182/2/cmake_modules/FindGumboParser.cmake@33 PS2, Line 33: find_library(GUMBO_PARSER_SHARED_LIB gumbo > What about replacing 'gumbo' with 'libgumbo${CMAKE_SHARED_LIBRARY_SUFFIX}'? CMAKE_SHARED_LIBRARY_SUFFIX on macOS is ".tbd;.dylib;.so;.a", so nope, it would not work. I also tried to set CMAKE_SHARED_LIBRARY_SUFFIX just for shared libs (i.e. '.so' on linux and '.dylib' on macOS) in the top-level CMakeLists.txt in $KUDU_ROOT, but it didn't work: if when using lib<name>.a for static library part, cmake could not find the static library (apparently, it needs '.a' to be in the suffix list even if lib<name>.a is given in find_library() function). Yep, I can do this in every other file in this patch. And next patch we could introduce a function/macro around find_library(), something find_static_library() and find_shared_library(). -- To view, visit http://gerrit.cloudera.org:8080/15182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e56b9dd988501af010bbd1a256671b0460f526 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Feb 2020 06:00:15 +0000 Gerrit-HasComments: Yes
