Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15182
to look at the new patch set (#2).
Change subject: [cmake_modules] shared libs for yaml and gumbo on macOS
......................................................................
[cmake_modules] shared libs for yaml and gumbo on macOS
I noticed that even in DEBUG build yaml and gumbo libraries were
linked in statically when building on macOS. It turned out the
system could not find shared libraries since their pattern contained
non-macOS '.so' suffix.
This patch address the issue: I verified that non-debug binaries
are linked dynamically with the libraries mentioned above.
I also added some extra work to protect against using static gumbo
library in place of the shared one. The approach could be applied
for other libraries as well, but I'm not sure it's worth it.
Change-Id: Ie1e56b9dd988501af010bbd1a256671b0460f526
---
M cmake_modules/FindGumboParser.cmake
M cmake_modules/FindGumboQuery.cmake
M cmake_modules/FindYaml.cmake
3 files changed, 16 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/15182/2
--
To view, visit http://gerrit.cloudera.org:8080/15182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1e56b9dd988501af010bbd1a256671b0460f526
Gerrit-Change-Number: 15182
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <[email protected]>
