Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15298 )
Change subject: WIP [ksck] report on misconfiguration of time source flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15298/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15298/1//COMMIT_MSG@10 PS1, Line 10: Particularly, with this patch : ksck issues a warning if different masters or different servers have : different settings for the following flags: : * --time_source : * --builtin_ntp_servers > Why is it important that all masters or all tservers share the same values Thank you for the feedback! Using different time source for different might be a sign of misconfiguration. In theory, we can allow using built-in NTP client for some servers and rely on local synchronized clocks on others, but I'm not sure this is a viable use case. So, if those flags have different values, it most likely a sign of misconfiguration. Do you think it's too much to warn about such a case? Yep, the verification that all masters _and_ tablet servers use the same source is in the making. I should have noted this as one of the WIP notes. -- To view, visit http://gerrit.cloudera.org:8080/15298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2afbfac9327f85b212ecf8d8f43a2139f90db6bb Gerrit-Change-Number: 15298 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2020 20:28:13 +0000 Gerrit-HasComments: Yes
