Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15298 )
Change subject: WIP [ksck] report on misconfiguration of time source flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15298/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15298/1//COMMIT_MSG@10 PS1, Line 10: Particularly, with this patch : ksck issues a warning if different masters or different servers have : different settings for the following flags: : * --time_source : * --builtin_ntp_servers > Thank you for the feedback! When ksck prints a warning, does it also exit with a non-zero status? If so, I'd be inclined not to warn here, as some folks may have good reason for the differing configuration. If not, then let's keep it. -- To view, visit http://gerrit.cloudera.org:8080/15298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2afbfac9327f85b212ecf8d8f43a2139f90db6bb Gerrit-Change-Number: 15298 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2020 20:33:06 +0000 Gerrit-HasComments: Yes
