Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15298 )
Change subject: [ksck] report on misconfiguration for flag categories ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15298/2/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/15298/2/src/kudu/tools/ksck.cc@245 PS2, Line 245: for (const auto& str : categories_str) { > Replaced with strings::Split(). Not sure I understand the 'embed it direct What I meant is this: for (const auto str : strings::Split(str, ...)) { // Operate on 'str'. } http://gerrit.cloudera.org:8080/#/c/15298/2/src/kudu/tools/ksck.cc@722 PS2, Line 722: tservers_flags.end(), > Nope, set_symmetric_difference needs elements to be ordered to operate corr I don't know, and unless you can show a meaningful difference in a profiler, I wouldn't bother. -- To view, visit http://gerrit.cloudera.org:8080/15298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2afbfac9327f85b212ecf8d8f43a2139f90db6bb Gerrit-Change-Number: 15298 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2020 21:39:18 +0000 Gerrit-HasComments: Yes
