Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15298 )
Change subject: [ksck] report on misconfiguration for flag categories ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15298/2/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/15298/2/src/kudu/tools/ksck.cc@245 PS2, Line 245: SplitStringUsing(str, ",", &categories_str); > What I meant is this: Ah, I see. That didn't work for me, so I'm leaving the temporary vector for now: [ 84%] Building CXX object src/kudu/tools/CMakeFiles/ksck.dir/ksck.cc.o src/kudu/tools/ksck.cc:246:19: error: no matching function for call to 'StringToFlagsCategory' RETURN_NOT_OK(StringToFlagsCategory(str, &cat)); ^~~~~~~~~~~~~~~~~~~~~ src/kudu/util/status.h:138:31: note: expanded from macro 'RETURN_NOT_OK' #define RETURN_NOT_OK KUDU_RETURN_NOT_OK ^ src/kudu/util/status.h:36:33: note: expanded from macro 'KUDU_RETURN_NOT_OK' const ::kudu::Status& _s = (s); \ ^ src/kudu/tools/ksck.cc:225:8: note: candidate function not viable: no known conversion from 'const StringPiece' to 'const std::__1::string' (aka 'const basic_string<char, char_traits<char>, allocator<char> >') for 1st argument Status StringToFlagsCategory(const string& str, FlagsCategory* category) { ^ 1 error generated. http://gerrit.cloudera.org:8080/#/c/15298/2/src/kudu/tools/ksck.cc@722 PS2, Line 722: set<KsckFlag> masters_flags; > I don't know, and unless you can show a meaningful difference in a profiler OK, I think we can keep std::set() for a while then and look for alternatives when there is a need to optimize for performance for some particular scenarios. -- To view, visit http://gerrit.cloudera.org:8080/15298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2afbfac9327f85b212ecf8d8f43a2139f90db6bb Gerrit-Change-Number: 15298 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2020 22:56:29 +0000 Gerrit-HasComments: Yes
