Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15298 )
Change subject: [ksck] report on misconfiguration for flag categories ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15298/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15298/1//COMMIT_MSG@10 PS1, Line 10: Particularly, with this patch : ksck issues a warning if different masters or different servers have : different settings for the following flags: : * --time_source : * --builtin_ntp_servers > When ksck prints a warning, does it also exit with a non-zero status? If so Printing warnings doesn't yield non-zero exit status. Additionally, in PS2, the verification of the uniformity for flags settings runs only if a particular flag is present. http://gerrit.cloudera.org:8080/#/c/15298/1//COMMIT_MSG@20 PS1, Line 20: * collect feedback on this approach: maybe, a better option is to : introduce new RPC methods into the GenericService interface : (see src/kudu/server/server_base.proto for details)? > FWIW, I think this flag-based approach is a good one. Thank you for the feedback. OK, let's keep it then :) http://gerrit.cloudera.org:8080/#/c/15298/1/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/15298/1/src/kudu/tools/ksck.h@598 PS1, Line 598: // Check for the consistent settings of the time source-related flags among : // all tablet servers in the cluster. : // Must first call FetchInfoFromTabletServers(). : Status CheckTabletServerTimeSourceFlags(); > I like this, but can you restructure the code so that it's not specific to Done. -- To view, visit http://gerrit.cloudera.org:8080/15298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2afbfac9327f85b212ecf8d8f43a2139f90db6bb Gerrit-Change-Number: 15298 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2020 05:38:05 +0000 Gerrit-HasComments: Yes
