Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15298 )
Change subject: [ksck] report on misconfiguration for flag categories ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15298/3/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/15298/3/src/kudu/tools/ksck.h@183 PS3, Line 183: // Flags specific to the time source, clock, and alike. : TIME_SOURCE = MIN, : : // Flags tagged hidden, experimental, or unsafe. : UNUSUAL = MIN + 1, nit: is it important that TIME_SOURCE will always be MIN? If not, maybe just define TIME_SOURCE and UNUSUAL as 0 and 1 respectively? Might be more quickly readable and more easily changeable in the future. http://gerrit.cloudera.org:8080/#/c/15298/3/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/15298/3/src/kudu/tools/ksck.cc@65 PS3, Line 65: comma nit: capitalize this -- To view, visit http://gerrit.cloudera.org:8080/15298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2afbfac9327f85b212ecf8d8f43a2139f90db6bb Gerrit-Change-Number: 15298 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 11 Mar 2020 00:58:25 +0000 Gerrit-HasComments: Yes
