Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 )
Change subject: [ranger] parameterize the Java binary path for the subprocess ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@145 PS1, Line 145: HISTINIT(sp > Done it can still exec the wrong binary though if there's another process in the PATH, for example this kept trying to load the wrong initdb that was in my PATH instead of the one I provided full path for: https://gerrit.cloudera.org/c/15374/2/src/kudu/ranger/mini_ranger.cc#67 If there's another java in the classpath I think this would load it that way. My workaround was to remove BaseName: https://gerrit.cloudera.org/c/15374/2/src/kudu/util/subprocess.cc#270 Hao can you double check this? -- To view, visit http://gerrit.cloudera.org:8080/15415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f23a4e96ec5fd29de0e6d598d4400f5ac92366 Gerrit-Change-Number: 15415 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 14 Mar 2020 20:42:22 +0000 Gerrit-HasComments: Yes
