Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 )
Change subject: [ranger] parameterize the Java binary path for the subprocess ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@145 PS1, Line 145: HISTINIT(sp > it can still exec the wrong binary though if there's another process in the Do you see that is a problem? If the kudu's user PATH can locate the Java binary, that should be desired by the user as mentioned in the description of the flag. http://gerrit.cloudera.org:8080/#/c/15415/3/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/3/src/kudu/ranger/ranger_client.cc@42 PS3, Line 42: path w > nit: remove Done -- To view, visit http://gerrit.cloudera.org:8080/15415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f23a4e96ec5fd29de0e6d598d4400f5ac92366 Gerrit-Change-Number: 15415 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 14 Mar 2020 22:05:01 +0000 Gerrit-HasComments: Yes
