Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 )
Change subject: KUDU-3079 Add MiniPostgres ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/15374/9/src/kudu/ranger/mini_postgres.cc File src/kudu/ranger/mini_postgres.cc: http://gerrit.cloudera.org:8080/#/c/15374/9/src/kudu/ranger/mini_postgres.cc@153 PS9, Line 153: db.Start()); > It would be nice to config to log to the data root dir of minipostgres, sim Shouldn't logs go be collected by glog? I thought that'd happen automatically by virtue of running as a Subprocess (assuming we've set stdout and stderr on the Subprocess). http://gerrit.cloudera.org:8080/#/c/15374/9/src/kudu/ranger/mini_postgres.cc@157 PS9, Line 157: : Status MiniPostgres > Yeah, mostly about the size of min_wal_size and max_wal_size. Will it ever Seems like these are the defaults. -- To view, visit http://gerrit.cloudera.org:8080/15374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba40126aa60e0ecbc5ae10cc1328493194c345bc Gerrit-Change-Number: 15374 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 20 Mar 2020 04:48:34 +0000 Gerrit-HasComments: Yes
