Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 )
Change subject: KUDU-3079 Add MiniPostgres ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/15374/9/src/kudu/ranger/mini_postgres.cc File src/kudu/ranger/mini_postgres.cc: http://gerrit.cloudera.org:8080/#/c/15374/9/src/kudu/ranger/mini_postgres.cc@153 PS9, Line 153: (); > Shouldn't logs go be collected by glog? I thought that'd happen automatical I don't feel strongly about this, but I think it's good to have as much logs as we can in the same file/stderr with the tests instead of having to look at different files. http://gerrit.cloudera.org:8080/#/c/15374/9/src/kudu/ranger/mini_postgres.cc@157 PS9, Line 157: Status MiniPostgres::CreateConfigs(const string& pg_root) { : Env* env = Env::D > Seems like these are the defaults. Yep, these are all the defaults. I don't want to change the defaults unless we have a reason to. I don't think they would get too large though, Ranger shouldn't store too much info in them for our testing scenarios. http://gerrit.cloudera.org:8080/#/c/15374/11/src/kudu/ranger/mini_postgres.cc File src/kudu/ranger/mini_postgres.cc: http://gerrit.cloudera.org:8080/#/c/15374/11/src/kudu/ranger/mini_postgres.cc@52 PS11, Line 52: be used by binding it explicitly. : Status GetRandomPort(uint16_t* port) { > Not quite following this. 'until it's in this state' refer to which state? yep, clarified http://gerrit.cloudera.org:8080/#/c/15374/11/src/kudu/ranger/mini_postgres.cc@160 PS11, Line 160: > This is the default configuration provided by postgresql? If so, can you ad Done -- To view, visit http://gerrit.cloudera.org:8080/15374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba40126aa60e0ecbc5ae10cc1328493194c345bc Gerrit-Change-Number: 15374 Gerrit-PatchSet: 13 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 20 Mar 2020 08:39:36 +0000 Gerrit-HasComments: Yes
