Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI to add master ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16530/2/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: PS2: > I updated dynamic-multi-master_test.cc to use this CLI tool exclusively sin Yes, I understand. Where do we have the coverage for the available flags and help string of this new tool? I don't see such one in dynamic-multi-master_test.cc As of now, all the tools available provided by the kudu binary have that coverage in TEST_F(ToolTest, TestModeHelp) It would be great to add one for this new tool as well. http://gerrit.cloudera.org:8080/#/c/16530/3/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/16530/3/src/kudu/tools/tool_action_master.cc@159 PS3, Line 159: if (resp.has_error()) { : return StatusFromPB(resp.error().status()); : } : : int i = 0; : b > Transient error like leadership change will be handled by LeaderMasterProxy Indeed -- this is a change in right direction, I think. -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 09 Feb 2021 17:26:23 +0000 Gerrit-HasComments: Yes
