Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI to add master ...................................................................... Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16530/8/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16530/8/src/kudu/master/dynamic_multi_master-test.cc@678 PS8, Line 678: return an error. nit: needs an update, same below http://gerrit.cloudera.org:8080/#/c/16530/8/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/16530/8/src/kudu/tools/tool_action_master.cc@146 PS8, Line 146: s.IsRemoteError() && s.ToString().find("Master already present") != string::npos; I wasn't a huge fan of relying on error messages to dictate behavior (e.g. vs adding some bool to the response) since it forces our hand in keeping this error message forever. It's a fine message, but in general we've shied away from it, though I guess we do this at least once in ksck. I suppose if this ever does lead to problems (e.g. if the error message ever changes) we could always build on this with a bool. -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 8 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 10 Feb 2021 02:02:20 +0000 Gerrit-HasComments: Yes
