Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI to add master ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/16530/8/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/16530/8/src/kudu/tools/tool_action_master.cc@146 PS8, Line 146: s.IsRemoteError() && s.ToString().find("Master already present") != string::npos; > I wasn't a huge fan of relying on error messages to dictate behavior (e.g. +1 I guess adding a new master-specific error code such as MASTER_ALREADY_PRESENT to MasterErrorPB shouldn't be a big deal? With that, there would be no need to rely on error messages. -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 8 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 10 Feb 2021 19:40:51 +0000 Gerrit-HasComments: Yes
