Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17129 )
Change subject: KUDU-3248: Match C++ replica selection behavior of Java client ...................................................................... KUDU-3248: Match C++ replica selection behavior of Java client The C++ client currently uses a new random value every time a replica is selected. Alternatively, the Java client uses a static value that ensures the selection for a single process or application remains deterministic. This patch adjusts the C++ implementation to match the Java client behavior. This is expected to be a good balance of efficient use of cache memory and distribution of load across the replicas given a single process will always get the same choice resulting in cache hits for follow up scans, but separate processes will get a potentially different random selection. The reviews on the Java patch here have some good context and discussion: https://gerrit.cloudera.org/#/c/12158/ Change-Id: Iaa55e88b4a222fabfaa7fa521c24482cc6816b04 Reviewed-on: http://gerrit.cloudera.org:8080/17129 Tested-by: Kudu Jenkins Reviewed-by: Attila Bukor <abu...@apache.org> --- M java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java M src/kudu/client/client-internal.cc M src/kudu/client/client-test.cc M src/kudu/client/client.h M src/kudu/common/common.proto M src/kudu/integration-tests/disk_failure-itest.cc M src/kudu/integration-tests/tablet_server_quiescing-itest.cc 7 files changed, 105 insertions(+), 19 deletions(-) Approvals: Kudu Jenkins: Verified Attila Bukor: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iaa55e88b4a222fabfaa7fa521c24482cc6816b04 Gerrit-Change-Number: 17129 Gerrit-PatchSet: 9 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120)