Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17129 )
Change subject: KUDU-3248: Match C++ replica selection behavior of Java client ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Per the Slack discussion, would be good to get numbers making sure this improves things before merging if we can. http://gerrit.cloudera.org:8080/#/c/17129/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17129/3//COMMIT_MSG@11 PS3, Line 11: ensure nit: ensures http://gerrit.cloudera.org:8080/#/c/17129/3//COMMIT_MSG@12 PS3, Line 12: implimentation nit: implementation http://gerrit.cloudera.org:8080/#/c/17129/3/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: http://gerrit.cloudera.org:8080/#/c/17129/3/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@66 PS3, Line 66: private static final int kRandomSelectionInt = new Random().nextInt(Integer.MAX_VALUE); nit: Google's Java styleguide suggests RANDOM_SELECTION_INT for constants. I suppose we're not that strict with following it though, given they suggest "logger" instead of "LOG" https://google.github.io/styleguide/javaguide.html#s5-naming -- To view, visit http://gerrit.cloudera.org:8080/17129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa55e88b4a222fabfaa7fa521c24482cc6816b04 Gerrit-Change-Number: 17129 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Feb 2021 21:56:27 +0000 Gerrit-HasComments: Yes
