Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17129 )

Change subject: KUDU-3248: Match C++ replica selection behavior of Java client
......................................................................


Patch Set 4: Code-Review+1

LGTM, but it seems some tests are failing.  It seems those failures are related 
to the change of the scans affinity, at least this looks a bit suspicious:

TServerQuiescingITest.TestDoesntAllowNewScans

/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/tablet_server_quiescing-itest.cc:253
Expected: (0) < (ts->server()->scanner_manager()->CountActiveScanners()), 
actual: 0 vs 0


--
To view, visit http://gerrit.cloudera.org:8080/17129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa55e88b4a222fabfaa7fa521c24482cc6816b04
Gerrit-Change-Number: 17129
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 27 Feb 2021 18:21:14 +0000
Gerrit-HasComments: No

Reply via email to