Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17129 )
Change subject: KUDU-3248: Match C++ replica selection behavior of Java client ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17129/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17129/3//COMMIT_MSG@15 PS3, Line 15: This is expected to be a good balance > That single process is itself not distributed in nature at that point and I Thank you for the explanation. Right: my concern was about distributing the IO load for requests issued from one client application. We also discussed this offline, and I agree that even with current implementation we didn't have any provision for better distribution of such IO load if looking at this from the point of using Kudu C++ client in impalad which is collocated with kudu-tserver, and impalad always worked with the local kudu-tserver. So, from that perspective we cannot talk about regressions anyways. http://gerrit.cloudera.org:8080/#/c/17129/3/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/17129/3/src/kudu/client/client-internal.cc@191 PS3, Line 191: still benefit from spreading the load across replicas > I didn't have a good reason to suspect that per-client would necessarily be SGTM. We also discussed this offline. Given that Impala is most likely the major user of Kudu C++ client, it seems the risk of exposing some API that nobody uses is higher than finding some unexpected use case where the former affinity behavior would be a better fit than the newly implemented one. -- To view, visit http://gerrit.cloudera.org:8080/17129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa55e88b4a222fabfaa7fa521c24482cc6816b04 Gerrit-Change-Number: 17129 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Feb 2021 22:11:52 +0000 Gerrit-HasComments: Yes
