Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17444 )
Change subject: KUDU-3223: Mangement of per-table limit by kudu cli ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17444/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17444/6/src/kudu/master/catalog_manager.cc@2898 PS6, Line 2898: ConfigurationError nit: Status::NotSupported() seems more appropriate. http://gerrit.cloudera.org:8080/#/c/17444/6/src/kudu/master/catalog_manager.cc@2900 PS6, Line 2900: enable_table_write_limit nit: we typically refer to gflags with two dashes, i.e. --enable_table_write_limit. Same below. -- To view, visit http://gerrit.cloudera.org:8080/17444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59bb64cc85d5fca48ae8ec980f5cfc62e4b3a1d3 Gerrit-Change-Number: 17444 Gerrit-PatchSet: 6 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 18 May 2021 00:31:05 +0000 Gerrit-HasComments: Yes
