Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17444 )
Change subject: KUDU-3223: Mangement of per-table limit by kudu cli ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/17444/7/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/17444/7/src/kudu/tools/tool_action_table.cc@1210 PS7, Line 1210: unique_ptr<Action> change_table_limit = : ClusterActionBuilder("change_table_limit", &ChangeTableLimit) : .Description("Change the disk size limit or row count limit") : .AddRequiredParameter({ kTableNameArg, "Name of the table to change limit" }) : .AddOptionalParameter("disk_size_limit") : .AddOptionalParameter("row_count_limit") : .Build(); > Good. It is a great idea to avoid using '-2'. Thanks for your suggestion. I'm not sure there's an elegant way to disambiguate negative numbers from flags. If not, here are a couple other options to work around it: - keep these optional parameters, e.g. with some --value flag (tricky because we would then need to pick a default value) - further specify the tool so that there is `set_limit disk_size_limit` and `set_limit clear_disk_size_limit` or something similar -- To view, visit http://gerrit.cloudera.org:8080/17444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59bb64cc85d5fca48ae8ec980f5cfc62e4b3a1d3 Gerrit-Change-Number: 17444 Gerrit-PatchSet: 7 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 18 May 2021 19:21:50 +0000 Gerrit-HasComments: Yes
